Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubectl-convert to client-binaries #99155

Merged
merged 2 commits into from Feb 23, 2021

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Feb 17, 2021

What type of PR is this?

/kind cleanup
/kind documentation

/sig cli
/sig release
/priority backlog

What this PR does / why we need it:

In #96190 I moved all the remaining bits of kubectl to staging repository. Per kubernetes/kubectl#725 it was decided that kubectl convert will become a plugin but I missed it in that PR. This should fix our release such that it will include kubectl-convert binaries along kubectl.

Which issue(s) this PR fixes:

Fixes #99076

Special notes for your reviewer:

/assign @liggitt @neolit123

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 17, 2021
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/release Categorizes an issue or PR as relevant to SIG Release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. priority/backlog Higher priority than priority/awaiting-more-evidence. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 17, 2021
@soltysh
Copy link
Contributor Author

soltysh commented Feb 17, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added area/kubectl triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 17, 2021
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I typically would not prefer to add a binary to our release artifacts that has already been removed from kubectl because of its dependencies. However, I also understand that kubectl-convert is pretty tightly coupled to k8s versions. I wonder how we feel about this compared to something like kubeadm, which has seen some motivation to be moved out of k/k. kubectl-convert is difficult because the same reason it was broken out from kubectl (dependency on internal types) seems to be the primary motivation for including it in k/k release process. Would like to discuss more before we commit to releasing as part of k/k because we are trying to minimize churn on the artifacts we are producing.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2021
@neolit123
Copy link
Member

neolit123 commented Feb 17, 2021

I typically would not prefer to add a binary to our release artifacts that has already been removed from kubectl because of its dependencies. However, I also understand that kubectl-convert is pretty tightly coupled to k8s versions. I wonder how we feel about this compared to something like kubeadm, which has seen some motivation to be moved out of k/k.

while we had plans to move kubeadm out of k/k the preference was to still continue releasing it as part of the k8s bundle.

kubectl-convert is difficult because the same reason it was broken out from kubectl (dependency on internal types) seems to be the primary motivation for including it in k/k release process. Would like to discuss more before we commit to releasing as part of k/k because we are trying to minimize churn on the artifacts we are producing.

i'm +1 on including kubectl-convert in the release, or if not kubectl-convert, a general mechanism to allow users to migrate their manifests on disk away from a unsupported API.

@hasheddan
Copy link
Contributor

Another thing to note is that we should actively be testing artifacts that are part of the k/k release bundles. Do we have periodic jobs exercising kubectl-convert functionality?

@justaugustus
Copy link
Member

+1 to @hasheddan's assessment. Will hold any comments from my side pending response.
/area release-eng

@k8s-ci-robot k8s-ci-robot added the area/release-eng Issues or PRs related to the Release Engineering subproject label Feb 17, 2021
@liggitt
Copy link
Member

liggitt commented Feb 17, 2021

kubectl-convert is difficult because the same reason it was broken out from kubectl (dependency on internal types) seems to be the primary motivation for including it in k/k release process.

Pairing kubectl-convert to the same release process as kube-apiserver makes sense to me, because that is the cadence at which changes to built-in types and conversion logic are released. The command is useful when users need to migrate their manifests from a deprecated version to a stable version. Requiring users to compile their own instance doesn't seem reasonable, so I think it should be built/released somehow.

That said, if the goal of kubectl cutting k8s.io/kubernetes dependencies was to allow it to have its own release, putting a new artifact explicitly coupled to the kube-apiserver release in the same bundle as kubectl seems like backtracking.

Another thing to note is that we should actively be testing artifacts that are part of the k/k release bundles. Do we have periodic jobs exercising kubectl-convert functionality?

+1 to testing.

@soltysh
Copy link
Contributor Author

soltysh commented Feb 18, 2021

Another thing to note is that we should actively be testing artifacts that are part of the k/k release bundles. Do we have periodic jobs exercising kubectl-convert functionality?

We used to have some test in test-cmd suite, lemme ensure they are properly testing kubectl-convert.

@liggitt liggitt added this to the v1.21 milestone Feb 18, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 19, 2021
@soltysh
Copy link
Contributor Author

soltysh commented Feb 19, 2021

Now with convert test in 2nd commit.

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 19, 2021
@dims
Copy link
Member

dims commented Feb 19, 2021

/approve

(/build and /hack changes look good)

@justaugustus
Copy link
Member

/retest

@justaugustus
Copy link
Member

justaugustus commented Feb 19, 2021

(Will drop an /approve for build/ on this once the verify test passes.)

@soltysh
Copy link
Contributor Author

soltysh commented Feb 22, 2021

(Will drop an /approve for build/ on this once the verify test passes.)

Fixed all the bits, should be good now.

Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel

Acknowledging that this is a special case and testing has been added.

/retest

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2021
@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, justaugustus, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit d6c7476 into kubernetes:master Feb 23, 2021
@soltysh soltysh deleted the convert_release branch February 23, 2021 15:13
@sftim
Copy link
Contributor

sftim commented Jun 30, 2021

Relevant to kubernetes/website#28724: Document how to install kubectl convert plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubectl-convert is not included in release artifacts
8 participants